rasterizer regression from flutter engine roll

This issue has been tracked since 2023-03-17.

description

The following benchmarks have experienced a regression as a result of a engine roll into the framework of about 16%:

  • 90th_percentile_frame_rasterizer_time_millis
  • 99th_percentile_frame_rasterizer_time_millis
  • average_frame_build_time_millis
  • average_frame_rasterizer_time_millis
  • worst_frame_rasterizer_time_millis

engine roll

#122851

potential culprits

skiaperf

https://flutter-flutter-perf.skia.org/e/?begin=1678999929&end=1679066557&keys=X8a7bf9165ee1430b7d0824948f07499a&selected=commit%3D33850%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DiPhone_11%252Cdevice_version%253Dnone%252Chost_type%253Dmac%252Csub_result%253D99th_percentile_frame_rasterizer_time_millis%252Ctest%253Dbackdrop_filter_perf_impeller_ios__timeline_summary%252C&xbaroffset=33850

gaaclarke wrote this answer on 2023-03-17

After reviewing all the possible PR's I believe the regression happened in flutter/engine#40356

jonahwilliams wrote this answer on 2023-03-17

This likely regressed because I added another command to the command buffer used for the blit pass, and we currently block on command completition:

#120399

More Details About Repo
Owner Name flutter
Repo Name flutter
Full Name flutter/flutter
Language Dart
Created Date 2015-03-06
Updated Date 2023-03-30
Star Count 151602
Watcher Count 3555
Fork Count 25000
Issue Count 11498

YOU MAY BE INTERESTED

Issue Title Created Date Updated Date