Annotation hidden on groups

This issue has been tracked since 2022-12-01.

in Karma V109 we are seeing some weird behaviour with the summary annotations in groups.
We have the following set so the summary annotation should always be visible:

    annotations:
      default:
        hidden: false
      visible:
        - summary
      order:
        - summary

but weve noticed that on grouped alerts, if the summary annotation is unique it shows up, but if its the same for all group members it moves to the bottom of the card and you can only see it by clicking the plus. This is unexpected behaviour as we have the app configured to always show summary annotation.

example:

There is no summary annotation displayed.

but if we click on the plus:

The summary annotation appears.

prymitive wrote this answer on 2022-12-02

This is unexpected behaviour as we have the app configured to always show summary annotation.

From https://github.com/prymitive/karma#alert-groups

Labels and annotations that are shared between all alerts are moved to the footer.

bsamsom wrote this answer on 2022-12-02

@prymitive is there a config option to always show the footer?

This seems unexpected, as its set to always show summary but doesnt always show the summary(as its hidden on the footer).

prymitive wrote this answer on 2022-12-02

I'm not sure if I follow.
Are you saying config options:

annotations:
      default:
        hidden: false
      visible:
        - summary
      order:
        - summary

don't work correctly

are you just surprised that annotations are deduplicated?

bsamsom wrote this answer on 2022-12-02

What im saying is that with:

annotations:
      default:
        hidden: false
      visible:
        - summary
      order:
        - summary

The summary isnt actually shown on the alert until you expand the alert, the way id expect it to work would be to see the summary without needding to expand the alert.

My assumption would be that:

      visible:
        - summary

Would have every alert show the summary by default without needed to expand it.

prymitive wrote this answer on 2022-12-02

I can't reproduce that

I've updated https://github.com/prymitive/karma/blob/main/demo/karma.yaml#L37 to include

annotations:
  default:
    hidden: false
  visible:
    - summary
  order:
    - summary

and after running make run-demo I see this:

Which seems correct.

And when I update the config to hide by default:

annotations:
  default:
    hidden: true
  visible:
    - summary
  order:
    - summary

I'm seeing this:

Which also seems fine.

bsamsom wrote this answer on 2022-12-02

maybe the
alertsPerGroup: 5
is fixing that for you, as its default expanding out to 5 alerts, if i click the minus to only show the first alert, i see the behaviour i mentioned.

prymitive wrote this answer on 2022-12-02

My assumption would be that:
      visible:
        - summary
Would have every alert show the summary by default without needed to expand it.

The screenshot you posted above shows summary expanded.
I'm confused what the issue is.

bsamsom wrote this answer on 2022-12-02

Your summary isnet in the footer as it doesnt fall into this:
Labels and annotations that are shared between all alerts are moved to the footer.
I was showing the missing help annotation, that is common to the alerts and is in the footer.

Sorry for not describing that well.

bsamsom wrote this answer on 2022-12-02

or really any of the common labels as well, the job, mount_point,region, and severity labels are all gone untill you expand the alert and see the footer.

prymitive wrote this answer on 2022-12-02

Right, so the footer is always hidden when there's only one alert shown, which is wrong.
I'll look into fixing that. Thanks

prymitive wrote this answer on 2022-12-02

Should be fixed in v0.110

bsamsom wrote this answer on 2022-12-02

Thank you very much, ill update to v0.110 today or tomorrow when I see it land in dockerhub.

bsamsom wrote this answer on 2022-12-02

Saw the new version get published, grabbed it and can confirm that my issue is resovled, Once again thank you very much @prymitive

Your Name

Your Comment

More Details About Repo

Owner Name	prymitive
Repo Name	karma
Full Name	prymitive/karma
Language	TypeScript
Created Date	2018-09-09
Updated Date	2023-03-17
Star Count	1921
Watcher Count	33
Fork Count	166
Issue Count	2

YOU MAY BE INTERESTED

Issue Title	Created Date	Updated Date