[proposal] Should we use height percentage or viewport height as offset

This issue has been tracked since 2019-02-13.

Hi,

Considering lots of devices with various dimensions should we use percentage or viewport height as offset instead of pixels?

Viewport coverage: https://caniuse.com/#feat=viewport-units

ameerthehacker wrote this answer on 2019-02-13

@rashidul0405 I believe for the current implementation is independent of the units that we use and it will remain simple that way! yet thanks for the suggestion

ameerthehacker wrote this answer on 2019-02-14

@rashidul0405 I'm closing this issue due to no activity please feel free to reopen it if you want to share more.

rashidul0405 wrote this answer on 2019-02-19

current implementation is independent of the units

@ameerthehacker Thanks for your response, does it support units other than "px" (pixels)

rhernandog wrote this answer on 2021-06-10

Hey, I'm super late for this, but looking at this:
https://github.com/twobin/react-lazyload/blob/master/src/index.jsx#L349

And this:
https://github.com/twobin/react-lazyload/blob/master/src/index.jsx#L362

You can pass a string such as '100vh' and it works. I made a test project and seems to work as expected in
lazyload-units

More Details About Repo
Owner Name twobin
Repo Name react-lazyload
Full Name twobin/react-lazyload
Language JavaScript
Created Date 2015-08-07
Updated Date 2022-11-29
Star Count 5639
Watcher Count 52
Fork Count 482
Issue Count 153

YOU MAY BE INTERESTED

Issue Title Created Date Updated Date